Update page title on publish confirmation page #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the page title to provide an indication to the user that the page is not just the view page for the manual, but a page for publishing it. Also remove the unused `:page_title` value, which was used by the old, legacy, layout but is not needed by the design system one.
ryanb-gds
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the page title to provide an indication to the user that the page is not just the view page for the manual, but a page for publishing it.
Also remove the unused
:page_titlevalue, which was used by the old, legacy, layout but is not needed by the design system one.Why
To make it easier to distinguish between tabs in the browser, and for consistency with the new discard confirmation page.
Trello
Trello card (this is for the discard page—this PR will bring the publish confirmation page in line with the changes made for the discard confirmation page)
Follow these steps if you are doing a Rails upgrade.