List draft sections on publish confirmation page #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The require for the button's javascript was missing (though functionally everything seems to be working OK).
mtaylorgds
force-pushed
the
consolidation-show-editors-on-publish-confirmation
branch
2 times, most recently
from
8aac656 to
87fb0c4
Compare
Update the manuals publish confirmation page to include a table listing the sections that are currently in a draft state and so whose changes will be included in the manual's publication. This is to help avoid sections getting published that are not ready, by making whoever is publishing aware of the changes that will be included (for example, when there are multiple people editing sections). The logic for the "last updated text" was already present on the manual's "show" view, so this has been extracted to a helper method and reused by the publish confirmation view.
Update the test to check for the table listing the sections to be published.
mtaylorgds
force-pushed
the
consolidation-show-editors-on-publish-confirmation
branch
from
291c37b to
7bcbad3
Compare
ryanb-gds
approved these changes
Aug 11, 2023
Thanks Ryan, I'll ask again next week for someone to merge/have another look. |
ryanb-gds
deleted the
consolidation-show-editors-on-publish-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the manuals publish confirmation page to include a table listing the sections that are currently in a draft state and so whose changes will be included in the manual's publication.
Why
To help avoid sections getting published that are not ready, by making whoever is publishing aware of the changes that will be included (for example, when there are multiple people editing sections).
Visuals
Before
After (with sections in draft status)
After (with no sections in draft status)
Technical notes
The logic for the "last updated text" was already present on the manual's "show" view, so this has been extracted to a helper method and reused by the publish confirmation view.
Trello
Trello card
Follow these steps if you are doing a Rails upgrade.