Fix spacing between govspeak headings and attachment #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headings don't have margin bottom in govspeak, so rely on elements following them to have top margin for spacing - when followed by an attachment, this is a problem because an attachment is a gem component and therefore doesn't have top margin - solution is to add bottom margin to headings that does not exceed the top margin of other elements, so if both are present they will overlap without a visual difference - but for attachments the space will be provided by this new bottom margin - only doing this for H2 for now as this is the only example of this problem in the wild and I'm hesitant to make sweeping changes to govspeak
andysellick
force-pushed
the
fix-govspeak-heading
branch
from
92edc79 to
8949159
Compare
AshGDS
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM - I noticed on the Issue that you mentioned you couldn't find an example page anymore, so I did a weird Google Search and managed to find one:
https://www.gov.uk/guidance/disposal-system-specifications
(The Google search was site:www.gov.uk "PDF" "Contents" "Corporate information" to try and find a page with similar content to the old page you had)
Looks like you can find more examples using that google search e.g. https://www.gov.uk/guidance/storage-guidance
|
@AshGDS thanks, great find. Are you happy with the visual diff? I'm not sure what's causing it, but it seems minor. |
|
@andysellick Looks OK to me 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Add a margin bottom to govspeak
H2elements.Visual Changes
Fixes #4072