Remove GOVUK_DISABLE_SEARCH_AUTOCOMPLETE feature flag
#4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
approved these changes
Jan 9, 2025
We are centralising the enabling/disabling of autocomplete in Search API v2 so we don't need individual feature flags across several apps and in the component itself. The rationale for being able to disable autocomplete centres on a scenario in which the underlying search engine returns unsuitable results. The `search_with_autocomplete` component degrades gracefully anyway when no suggestions are returned, so we are moving to a simpler setup where there is a feature flag on Search API v2 to force returning empty responses instead.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We are centralising the enabling/disabling of autocomplete in Search API v2 so we don't need individual feature flags across several apps and in the component itself.
Why
The rationale for being able to disable autocomplete centres on a scenario in which the underlying search engine returns unsuitable results. The
search_with_autocompletecomponent degrades gracefully anyway when no suggestions are returned, so we are moving to a simpler setup where there is a feature flag on Search API v2 to force returning empty responses instead.Depends on alphagov/search-api-v2#375