Fix chart minimal option #4427
Merged
Fix chart minimal option #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wasn't hiding legend, removing interactivity, or reducing point size automatically based on the minimal setting, as it should have
AshGDS
approved these changes
Nov 22, 2024
|
I think it was probably that there were so many visual changes it was hard to spot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the
minimaloption in the chart component, because it wasn't hiding the legend, removing interactivity, or reducing point size automatically, as it should have been.Why
Managed to break this as part of #4424
Visual Changes
None (except to fix minimal mode back to what it should be).