Remove breadcrumbs example from inverse_header docs #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
approved these changes
Sep 20, 2024
hannalaakso
reviewed
Sep 23, 2024
app/views/govuk_publishing_components/components/docs/inverse_header.yml
Outdated
Show resolved
Hide resolved
It's not possible to include the breadcrumbs inside the header component without ending up with a WCAG fail because the variant places it inside the <main> container since the header itself is inside the main. Also updated the `with_link` example to be `with_paragraph_and_link`
MartinJJones
force-pushed
the
remove-breadcrumbs-example-from-inverse-header
branch
from
9f4d63f to
a5085eb
Compare
hannalaakso
approved these changes
Sep 23, 2024
MartinJJones
deleted the
remove-breadcrumbs-example-from-inverse-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove breadcrumbs example from inverse header component documentation
Trello card
Why
It's not possible to include the breadcrumbs inside the header component without ending up with a WCAG fail because the variant places it inside the
<main>container since the header itself is insidemain.