Require sidekiq/api in GovukPrometheusExporter #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
reviewed
Jun 15, 2023
AgaDufrat
force-pushed
the
update-prometheus-exporter
branch
from
95c6609 to
5266ca5
Compare
sengi
approved these changes
Jun 15, 2023
AgaDufrat
force-pushed
the
update-prometheus-exporter
branch
from
5266ca5 to
c19c381
Compare
The workers were erroring with: ``` PrometheusExporter::Instrumentation::SidekiqProcess Prometheus Exporter Failed To Collect Stats uninitialized constant Sidekiq::Process PrometheusExporter::Instrumentation::SidekiqQueue Prometheus Exporter Failed To Collect Stats uninitialized constant Sidekiq::Queue PrometheusExporter::Instrumentation::SidekiqStats Prometheus Exporter Failed To Collect Stats uninitialized constant Sidekiq::Stats ``` and failing to send metrics following a switch from Statsd to Prometheus Exporter: alphagov/govuk_sidekiq@763144d Sidekiq::Process, Sidekiq::Queue, Sidekiq::Stats are defined in Sidekiq API. It appears that to get access to the functionality the API needs to be required See https://github.com/sidekiq/sidekiq/wiki/API
AgaDufrat
force-pushed
the
update-prometheus-exporter
branch
from
c19c381 to
e898029
Compare
|
Thanks for fixing this! 🙇✨ |
sengi
reviewed
Jun 15, 2023
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # Unreleased | |||
There was a problem hiding this comment.
Totes optional: in case you wanna get this out quickly, feel free to do the 8.0.2 release in this PR (entirely up to you though, just mentioning in case it saves you time/hassle of getting another review for essentially the same change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The workers were erroring with:
and failing to send metrics following a switch from Statsd to Prometheus Exporter: alphagov/govuk_sidekiq@763144d
Sidekiq::Process, Sidekiq::Queue, Sidekiq::Stats are defined in Sidekiq API. It appears that to get access to the functionality, the API needs to be required. See https://github.com/sidekiq/sidekiq/wiki/API
Resolves #298
Testing
Tested in integration. Logs showing no errors