Add region1.google-analytics.com to CSP #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should update the [Content Security Policy (CSP)](https://github.com/alphagov/govuk_app_config/blob/4c7198b26acdb096be318c7aa343d46f02b7728d/lib/govuk_app_config/govuk_content_security_policy.rb) with `region1.google-analytics.com`. The current CSP is throwing intermittent errors [on integration](https://www.integration.publishing.service.gov.uk/).
gclssvglx
force-pushed
the
add-google-analytics-to-csp
branch
from
b25078e to
141334f
Compare
JonathanHallam
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
If this works we probably want to remove the www. line. Happy to approve for now to get smokey running properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We should update the Content Security Policy (CSP) with
region1.google-analytics.com.Why
The current CSP is throwing intermittent errors on integration.
Screenshots
Trello