Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0.pre.2 #202

Merged
merged 4 commits into from
Jun 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 4.0.0.pre-2

- Fix default Sentry configuration ([#202](https://github.com/alphagov/govuk_app_config/pull/202)).
- BREAKING: this means no more `silence_ready` or `transport_failure_callback` options.

# 4.0.0.pre-1

- BREAKING: upgrades Sentry gem from `sentry-raven` to `sentry-ruby` ([#199](https://github.com/alphagov/govuk_app_config/pull/199)). There is a **[migration guide](https://docs.sentry.io/platforms/ruby/migration/)** you should follow before upgrading to this version of govuk_app_config.
Expand Down
6 changes: 0 additions & 6 deletions lib/govuk_app_config/govuk_error/configure.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
GovukError.configure do |config|
config.silence_ready = !Rails.env.production? if defined?(Rails)

# These are the environments (described by the `SENTRY_CURRENT_ENV`
# ENV variable) where we want to capture Sentry errors. If
# `SENTRY_CURRENT_ENV` isn't in this list, or isn't defined, then
Expand Down Expand Up @@ -61,8 +59,4 @@
config.before_send = lambda { |error_or_event, _hint|
error_or_event
}

config.transport_failure_callback = proc {
GovukStatsd.increment("error_reports_failed")
}
end
2 changes: 1 addition & 1 deletion lib/govuk_app_config/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module GovukAppConfig
VERSION = "4.0.0.pre.1".freeze
VERSION = "4.0.0.pre.2".freeze
end
9 changes: 9 additions & 0 deletions spec/govuk_error/configure_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
require "spec_helper"
require "sentry-ruby"
require "govuk_app_config/govuk_error"

RSpec.describe "GovukError.configure" do
it "should contain only valid Sentry config" do
require "govuk_app_config/govuk_error/configure"
end
end