Add two missing Google domains to Content Security Policy #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
update-csp
branch
from
efbd734 to
ff5652d
Compare
We are making requests to www.googletagmanager.com in govuk_publishing_components [1] but have not allowed this domain in the Content Security Policy, so requests are getting blocked. 1: https://github.com/alphagov/govuk_publishing_components/blob/21e5808e03e7c97721cefe533b315753db7c5403/app/views/govuk_publishing_components/components/_google_tag_manager_script.html.erb#L16
JavaScript and CSS from www.gstatic.com are being used in content-data-admin [1], but were being blocked by the Content Security Policy. Therefore adding this domain to the policy. 1: https://github.com/alphagov/content-data-admin/blob/2bbf6cd4bbae29ec02107f4341d526f7707be6d6/app/views/layouts/application.html.erb#L2
brucebolt
force-pushed
the
update-csp
branch
from
ff5652d to
04e1d4d
Compare
cbaines
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making requests to www.googletagmanager.com in govuk_publishing_components [1], and including JavaScript and CSS from www.gstatic.com in content-data-admin [2]. All were being blocked by the Content Security Policy, therefore adding these domains to the policy.
1: https://github.com/alphagov/govuk_publishing_components/blob/21e5808e03e7c97721cefe533b315753db7c5403/app/views/govuk_publishing_components/components/_google_tag_manager_script.html.erb#L16
2: https://github.com/alphagov/content-data-admin/blob/2bbf6cd4bbae29ec02107f4341d526f7707be6d6/app/views/layouts/application.html.erb#L2