Revert rails_report_rescued_exceptions = false #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this setting was more aggressive than we anticipated and was actually preventing the reporting of any exception that Rails handled. We had thought that this only prevented the reporting of exceptions specially configured as Rails rescue responses. It transpires that this stops the reporting of any exceptions that are handled by ActionDispatch::ShowExceptions [1] which is effectively all Rails exceptions as per raven-ruby [2]. [1]: https://github.com/rails/rails/blob/38ec8db3f7d3c79936cdaa0a136b26ee1c977f7d/actionpack/lib/action_dispatch/middleware/show_exceptions.rb [2]: https://github.com/getsentry/raven-ruby/blob/d9d41784c3b5888295bf4b013416f132045b22d4/lib/raven/integrations/rails.rb#L51-L52
This adds in all the Rails default exceptions as is listed in: https://github.com/rails/rails/blob/38ec8db3f7d3c79936cdaa0a136b26ee1c977f7d/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb and removes a legacy exception that was removed in Rails 4. I did consider doing something like: ``` if defined?(ActionDispatch) config.excluded_exceptions += ActionDispatch::ExceptionWrapper.rescue_responses.keys end ``` but I thought it was a bit opaque, particularly because the rescue_responses attribute is edited during Rails initialisation, so could be hard to understand why this had a particular setting.
thomasleese
approved these changes
Mar 17, 2020
kevindew
added a commit
that referenced
this pull request
Mar 17, 2020
* Revert using Sentry option of rails_report_rescued_exceptions (#140)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #138
It turns out that this setting was more aggressive than we anticipated
and was actually preventing the reporting of any exception that Rails
handled. We had thought that this only prevented the reporting of
exceptions specially configured as Rails rescue responses.
It transpires that this stops the reporting of any exceptions that are
handled by ActionDispatch::ShowExceptions 1 which is effectively all
Rails exceptions as per raven-ruby 2.