Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up the 'Import CSS, assets and JavaScript' page #438

Merged
merged 26 commits into from
Apr 26, 2024

Conversation

claireashworth
Copy link
Contributor

Split up the 'Import CSS, assets and JavaScript' page into 3 separate pages – the original page and 2 new page for 'fonts and images' and 'JavaScript'

@claireashworth claireashworth added the documentation Improvements or additions to documentation label Apr 22, 2024
@claireashworth claireashworth self-assigned this Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for govuk-frontend-docs-preview ready!

Name Link
🔨 Latest commit 7920584
🔍 Latest deploy log https://app.netlify.com/sites/govuk-frontend-docs-preview/deploys/662910b8d4227900083e920a
😎 Deploy Preview https://deploy-preview-438--govuk-frontend-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@claireashworth claireashworth linked an issue Apr 22, 2024 that may be closed by this pull request
2 tasks
claireashworth and others added 9 commits April 22, 2024 16:04
…new pages

Removed original content
Added information about new content locations with links
Added hide navigation and indexing
The links were set with their final URL once deployed. Instead, using relative links ensure they'll lead to the right place regardless of where we're looking (dev, deploy preview for the PR or production
Points them to the relevant page and ensure they use relative links (or just a URL hash when linking inside the same page).

Also fixed a couple of typos where the URLs had a `/` after the hash, which confused browsers.
…page

The property in the frontmatter was making the page appear in the menu despite the `hide_from_navigation`.
Ensures it's lowercase so that things work fine on case sensitive systems
@romaricpascal romaricpascal force-pushed the new-pages-for-importing-assets-and-javascript branch from df2551c to 5f335c8 Compare April 23, 2024 17:39
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 💪🏻

owenatgov added a commit to alphagov/govuk-design-system that referenced this pull request Apr 26, 2024
@claireashworth claireashworth merged commit cc80cf5 into main Apr 26, 2024
5 checks passed
@claireashworth claireashworth deleted the new-pages-for-importing-assets-and-javascript branch April 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Split up or re-organise the 'Import CSS, assets and JavaScript' page
3 participants