-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up the 'Import CSS, assets and JavaScript' page #438
Merged
claireashworth
merged 26 commits into
main
from
new-pages-for-importing-assets-and-javascript
Apr 26, 2024
Merged
Split up the 'Import CSS, assets and JavaScript' page #438
claireashworth
merged 26 commits into
main
from
new-pages-for-importing-assets-and-javascript
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
…new pages Removed original content Added information about new content locations with links Added hide navigation and indexing
The links were set with their final URL once deployed. Instead, using relative links ensure they'll lead to the right place regardless of where we're looking (dev, deploy preview for the PR or production
Points them to the relevant page and ensure they use relative links (or just a URL hash when linking inside the same page). Also fixed a couple of typos where the URLs had a `/` after the hash, which confused browsers.
…page The property in the frontmatter was making the page appear in the menu despite the `hide_from_navigation`.
Ensures it's lowercase so that things work fine on case sensitive systems
df2551c
to
5f335c8
Compare
The page link points to a page we've split into 3 new pages. Removing for now and will address any content amendments in a future update of this page.
owenatgov
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 💪🏻
owenatgov
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Apr 26, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the 'Import CSS, assets and JavaScript' page into 3 separate pages – the original page and 2 new page for 'fonts and images' and 'JavaScript'