Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Travel advice alert status should be enum or removed #568

Open
fofr opened this issue Mar 14, 2017 · 0 comments
Open

Travel advice alert status should be enum or removed #568

fofr opened this issue Mar 14, 2017 · 0 comments

Comments

@fofr
Copy link
Contributor

fofr commented Mar 14, 2017

  • The alert status feature of travel advice isn't actively used, it could be removed from the publisher, schema and frontend
  • Alternatively, the alert status is set to one of a defined set of values, it should be an enum locked down to just those values.

https://github.com/alphagov/travel-advice-publisher/blob/5650462b5d11b7cc86d95c2f4e4470c8eaf71c9f/app/models/travel_advice_edition.rb#L30-L35

https://github.com/alphagov/govuk-content-schemas/blob/master/formats/travel_advice/publisher/details.json#L33-L37

fofr added a commit to alphagov/government-frontend that referenced this issue Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant