Allow data attributes in span tags #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work we’re doing in Content Modelling means we will be rendering content blocks within span tags with data attributes, which will make identifying content blocks easier. As we may be re-presenting content block embeds to Govspeak, we need to ensure that these tags don’t get stripped out, so we need to add `data-*` attributes to the allowlist for span tags.
pezholio
force-pushed
the
allow-data-attributes-in-spans
branch
from
673f36c to
da5d537
Compare
brucebolt
reviewed
Nov 18, 2024
pezholio
force-pushed
the
allow-data-attributes-in-spans
branch
from
da5d537 to
98b6cf5
Compare
brucebolt
approved these changes
Nov 18, 2024
CHANGELOG.md
Outdated
| @@ -1,4 +1,8 @@ | |||
| # 8.6.1 | |||
| # 8.7.0 | |||
There was a problem hiding this comment.
Could you make this a h2 (##) so it's consistent with the other entries?
pezholio
force-pushed
the
allow-data-attributes-in-spans
branch
from
98b6cf5 to
a48907c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work we’re doing in Content Modelling means we will be rendering content blocks within span tags with data attributes, which will make identifying content blocks easier. As we may be re-presenting content block embeds to Govspeak, we need to ensure that these tags don’t get stripped out, so we need to add
data-*attributes to the allowlist for span tags.