Add margin-bottom to embedded attachments #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds margin-bottom to embedded attachments. Without this, attachments have zero margin-bottom, meaning they look visually 'squished up' when multiple attachments are embedded one after the other in a document. This styling makes it consistent with the 'Documents' section that automatically gets added to some document types (for example, Publications in Whitehall).
brucebolt
approved these changes
Jul 12, 2023
|
You'll need to republish every document with an attachment once the gem has been bumped in the relevant publishing app. |
brucebolt
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an enabler for: https://trello.com/c/Z5IwGrAw/1177-remove-custom-attachment-rendering-from-whitehall
What
This change adds margin-bottom to embedded attachments.
Without this, attachments have zero margin-bottom, meaning they look visually 'squished up' when multiple attachments are embedded one after the other in a document.
This styling also makes it consistent with the 'Documents' section that automatically gets added to some document types (for example, Publications in Whitehall).
Visual changes
In this example, multiple attachments have been embedded into the document one after the other.
Some pseudo Govspeak for this would be:
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.