Fix Sentry error "undefined method `any?' for nil" #3549
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
reviewed
Feb 6, 2025
| @@ -115,7 +115,7 @@ | |||
| padding: true | |||
| } %> | |||
|
|
|||
| <% if @content_item.corporate_information_pages.any? %> | |||
| <% if @content_item.corporate_information_pages&.any? %> | |||
There was a problem hiding this comment.
Maybe .present? is more readable?
unoduetre
force-pushed
the
fix-sentry-error-undefined-method-any-for-nil
branch
from
dbb660d to
18eafd4
Compare
hannako
reviewed
Feb 6, 2025
| @@ -115,7 +115,7 @@ | |||
| padding: true | |||
| } %> | |||
|
|
|||
| <% if @content_item.corporate_information_pages.any? %> | |||
| <% if @content_item.corporate_information_pages&.present? %> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Right, I somehow missed that.
ActionView::Template::Error undefined method `any?' for nil (ActionView::Template::Error) NoMethodError undefined method `any?' for nil (NoMethodError) https://govuk.sentry.io/issues/5249728298/
unoduetre
force-pushed
the
fix-sentry-error-undefined-method-any-for-nil
branch
from
18eafd4 to
9caaf34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.
What
This PR fixes a Sentry error
Why
In preparation for Rails 8 migration, we are checking for the Sentry errors in order to discover any regressions. It turned out this error is not related to the upgrade, but it's easy to fix, so this PR was created.