Handle incorrectly UTF-8 encoded query and cookie url #3371
Conversation
unoduetre
changed the base branch from
main
to
set-show-exceptions-in-tests-to-none
Use a different exception when this situation is detected: * Sanitiser::Strategy::SanitisingError This error is not sent to Sentry. See: alphagov/govuk_app_config#402
unoduetre
force-pushed
the
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l
branch
from
3157aff to
9b5f383
Compare
There was a problem hiding this comment.
Sorry Mat I'm not really following this code so I've asked a lot of questions!
If you're confident in these settings it might be helpful to split the commits and explain the options you're passing in, with links to documentation.
I'm wondering if some of the complexity you've added is because you're trying to raise a single error type, so you only have to add that single exception in app-config? But looking at https://github.com/alphagov/govuk_app_config/blob/7b8d4536bf8f54a65694d3e17048d77d60355951/lib/govuk_app_config/govuk_error/configuration.rb#L31-L32 I think it's fine to add more than one error type from the same middleware to this file. So keeping the config in the frontend apps simple is maybe more important.
There was a problem hiding this comment.
Thanks for explaining Mat!
Shall we put this branch on integration and see if we can trigger some of the new errors in our tech channel before we merge alphagov/govuk_app_config#402 ?
I've already tested it on integration. Here is the error produced (which will be ignored after the govuk_app_config PR is merged) for the URL: "https://integration.publishing.service.gov.uk/update-uk-visas-immigration-account-details?%AD": If you want to test more, I can deploy it again. |
Great! No need to test any more feel free to merge tomorrow 👍 |
|
|
|
I need to recreate this PR as there are some issues with the tests. |
Follow these steps if you are doing a Rails upgrade.
What
Stop sentry alerting on the “invalid byte sequence in UTF-8 errors”.
As discussed with @hannako, we will use a a solution based on an external gem called
rack-utf8_sanitizerinstead of developing our own gem. This solution will then be used in all our apps by copy-pasting the configuration of this gem.Why
When security scanning of our site takes place we are inundated with these errors in our slack channel. These errors are not serving any purpose since there is no issue to be solved. Therefore we should remove them to keep all our alerts actionable.
We often get exceptions in Sentry coming from a security checking bot that attempts some attacks by using strings with special characters. All of those "attacks" fail, but they produce exceptions which we would like to ignore, so they do not clutter Sentry. On the other hand we don’t want to ignore exceptions of the same class coming from other sources.
Trello card