Skip to content

Commit

Permalink
Merge pull request #292 from alphagov/fix-deprecation-warning
Browse files Browse the repository at this point in the history
Fix deprecation warning
  • Loading branch information
chrislo authored Feb 5, 2024
2 parents 2242195 + ada0511 commit 8cc1427
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
## Unreleased

# 19.0.0

* We no longer set `ActiveSupport::Cache::NullStore.new` as the default cache. This avoids a deprecation warning when the gem is used in Rails apps.
* If you're using `gds-sso` in a Rails app and [relying on the Railtie](https://github.com/alphagov/gds-sso/blob/main/lib/gds-sso/railtie.rb#L6) to set the cache then you don't need to do anything
* If you're using `gds-sso` and manually setting the cache then you don't need to do anything.
* If you're using `gds-sso` outside of a Rails app and you're not explicitly setting the cache then you'll need to configure it before you can use `GDS::SSO::BearerToken.locate`.

# 18.1.0

* Enable [OAuth2 PKCE extension](https://datatracker.ietf.org/doc/html/rfc7636) in the GDS OAuth2 OmniAuth Strategy. The [PKCE extension was enabled in Signon in PR 2312](https://github.com/alphagov/signon/pull/2312).
Expand Down
1 change: 0 additions & 1 deletion lib/gds-sso/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module Config
@@auth_valid_for = 20 * 3600

mattr_accessor :cache
@@cache = ActiveSupport::Cache::NullStore.new

mattr_accessor :api_only

Expand Down
2 changes: 1 addition & 1 deletion lib/gds-sso/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module GDS
module SSO
VERSION = "18.1.0".freeze
VERSION = "19.0.0".freeze
end
end

0 comments on commit 8cc1427

Please sign in to comment.