-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR Store allowed email domain list as file in forms deploy #128
Merged
lfdebrux
merged 1 commit into
main
from
ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy
Jan 31, 2024
Merged
Add ADR Store allowed email domain list as file in forms deploy #128
lfdebrux
merged 1 commit into
main
from
ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBiddle
reviewed
Jan 15, 2024
ADR/ADRYYY-store-allowed-domain-list-as-file-in-forms-deploy.md
Outdated
Show resolved
Hide resolved
ADR/ADRYYY-store-allowed-domain-list-as-file-in-forms-deploy.md
Outdated
Show resolved
Hide resolved
ADR/ADRYYY-store-allowed-domain-list-as-file-in-forms-deploy.md
Outdated
Show resolved
Hide resolved
danworth
reviewed
Jan 17, 2024
ADR/ADRYYY-store-allowed-domain-list-as-file-in-forms-deploy.md
Outdated
Show resolved
Hide resolved
599daba
to
0ddaa24
Compare
57ca9d5
to
bee183d
Compare
6dc4b47
to
694916f
Compare
DavidBiddle
reviewed
Jan 31, 2024
ADR/ADR024-store-allowed-domain-list-as-file-in-forms-deploy.md
Outdated
Show resolved
Hide resolved
DavidBiddle
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really well written and explained ADR. The decision seems sensible and matches what we've discussed on the tech team previously.
Spotted one tiny typo but otherwise looks great 🎉
694916f
to
a214daf
Compare
DavidBiddle
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Trello ticket: https://trello.com/c/7Wfx1tI5/1255-spike-how-to-support-allow-deny-lists-from-a-shared-source
How to review
Describe the steps required to test the changes.
For example:
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.