Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR Store allowed email domain list as file in forms deploy #128

Merged

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Jan 15, 2024

What

Trello ticket: https://trello.com/c/7Wfx1tI5/1255-spike-how-to-support-allow-deny-lists-from-a-shared-source

How to review

Describe the steps required to test the changes.

For example:

  1. Semantic: Do you agree with the changes?
  2. Syntactic: Spelling, grammar, etc.

Who can review

Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.

@lfdebrux lfdebrux self-assigned this Jan 16, 2024
@lfdebrux lfdebrux requested a review from a team January 16, 2024 10:21
@lfdebrux lfdebrux force-pushed the ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy branch 2 times, most recently from 599daba to 0ddaa24 Compare January 19, 2024 14:51
@lfdebrux lfdebrux force-pushed the ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy branch 2 times, most recently from 57ca9d5 to bee183d Compare January 29, 2024 10:20
@lfdebrux lfdebrux changed the title wip! Add ADR Store allowed email domain list as file in forms deploy Add ADR Store allowed email domain list as file in forms deploy Jan 29, 2024
@lfdebrux lfdebrux marked this pull request as ready for review January 29, 2024 11:10
@lfdebrux lfdebrux force-pushed the ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy branch 2 times, most recently from 6dc4b47 to 694916f Compare January 30, 2024 06:44
DavidBiddle
DavidBiddle previously approved these changes Jan 31, 2024
Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well written and explained ADR. The decision seems sensible and matches what we've discussed on the tech team previously.

Spotted one tiny typo but otherwise looks great 🎉

@lfdebrux lfdebrux force-pushed the ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy branch from 694916f to a214daf Compare January 31, 2024 12:00
@lfdebrux lfdebrux merged commit 61cb2c1 into main Jan 31, 2024
@lfdebrux lfdebrux deleted the ldeb-add-adr-store-allowed-domain-list-as-file-in-forms-deploy branch January 31, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants