Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dfe autocomplete #1203

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update dfe autocomplete #1203

merged 2 commits into from
Feb 11, 2025

Conversation

DavidBiddle
Copy link
Contributor

@DavidBiddle DavidBiddle commented Feb 11, 2025

What problem does this pull request solve?

Trello card: related to https://trello.com/c/EU0NKwCA/2047-raise-pr-on-accessibility-issue-with-dfe-autocomplete-component

Updates to the latest dfe-autocomplete and makes a small update to the way we import it.

Changes in this release: DFE-Digital/dfe-autocomplete@8e7389f...1d4cc65

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle marked this pull request as ready for review February 11, 2025 15:31
Updates to the latest dfe-autocomplete. See full changes here:
DFE-Digital/dfe-autocomplete@8e7389f...1d4cc65
The latest dfe-autocomplete release (see previous commit) includes a
change to make importing sass directly from the node package root
possible.

This commit updates our code to import from the package root, as we
already do for govuk-frontend.
@DavidBiddle DavidBiddle force-pushed the update-dfe-autocomplete branch from dfc8f0b to 3ba5ca7 Compare February 11, 2025 15:31
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and this is using the new version of the autocomplete without the suggestions cue.

@DavidBiddle DavidBiddle merged commit 6ea3803 into main Feb 11, 2025
4 checks passed
@DavidBiddle DavidBiddle deleted the update-dfe-autocomplete branch February 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants