Keep FormDocuments up to date in V1 API calls #586
+269
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table api_v2_form_documents uses form_id as a foreign key. Deleting a form will raise an error if there are associated form_documents. This commit adds a has_many association to the Form and Api::V2::Form models. This ensures that any form_documents are deleting before any Form is removed to that no error is thrown from the db.
Uses of the V1 API should update the V2 FormDocument so they can be used in the responses from the V2 API. This commit introduces a new class, awkwardly name ModelSync. This class will be used in the V1 API to keep FormDocuments in sync. It calls the conversion function with the contents of a form_blob and creates, updates and deletes form_documents as needed.
The V1 API should also change the V2 API models. This commit adds calls to the ModelSync class to update FormDocuments during V1 API calls.
When creating, updating, moving and deleting pages, the draft form document must be kept up to date. This will allow the V2 API to serve matching form documents.
The V1 API needs to keep FormDocuments up to date. This commit updates FormDocuments when forms are made live and archived. Controller tests are added for the FormController but most of the work happens within the state machine. Calls to the ModelSync class are made on transistions.
thomasiles
force-pushed
the
update-form-document
branch
from
a37bfc9 to
802b093
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the V2 API models are updated from V1 API calls
Trello card: https://trello.com/c/l48nxEEO/1789-8-add-a-form-documents-table-to-forms-api
Things to consider when reviewing