Merge pull request #2371 from alphagov/dependabot/bundler/rubocop-gov…

…uk-5.0.8 Bump rubocop-govuk from 5.0.7 to 5.0.8
alphagov · Jan 31, 2025 · 1c9c117 · 1c9c117
2 parents f126a78 + 38f9e19
commit 1c9c117
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -626,7 +626,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.1)
-    rubocop (1.69.2)
+    rubocop (1.70.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -640,8 +640,8 @@ GEM
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
-    rubocop-govuk (5.0.7)
-      rubocop (= 1.69.2)
+    rubocop-govuk (5.0.8)
+      rubocop (= 1.70.0)
       rubocop-ast (= 1.37.0)
       rubocop-capybara (= 2.21.0)
       rubocop-rails (= 2.28.0)

diff --git a/app/validators/status_prerequisite_validator.rb b/app/validators/status_prerequisite_validator.rb
@@ -30,10 +30,8 @@ def validate_each(record, attribute, value)
   def can_be_in_review?(record)
     record.has_draft? &&
       record.reviewer_id.present? &&
-      (
-        record.status_was == "submitted_for_2i" ||
-        record.status_was == "in_review"
-      )
+
+      %w[submitted_for_2i in_review].include?(record.status_was)
   end
 
   def can_be_scheduled?(record)