Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed job name #325

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fixed job name #325

merged 1 commit into from
Dec 24, 2023

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Dec 21, 2023

This commit fixes the uniqueness of job names, which it is helpful mostly in the scheduler.

Before this commit, the job name is composed of the step name and the last tag level of its inputs. However, only the last tag level is not correct because some jobs could have the same name.
In particular, nested scatter can generate tags such as 0.0.0 and 0.1.0, thus the jobs will have the same name, i.e. step_name/0.
Now, the entire tag is used as identifier.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1783549) 67.09% compared to head (e1eb89d) 67.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   67.09%   67.11%   +0.01%     
==========================================
  Files          82       82              
  Lines       10254    10254              
  Branches     2425     2425              
==========================================
+ Hits         6880     6882       +2     
+ Misses       2950     2949       -1     
+ Partials      424      423       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit 7a1cf45 into master Dec 24, 2023
31 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/unique-job-name branch December 24, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants