Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed data location invalidation #324

Merged
merged 16 commits into from
Dec 23, 2023
Merged

Fixed data location invalidation #324

merged 16 commits into from
Dec 23, 2023

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Dec 19, 2023

This commit fixes the invalidation of the location in the filesystem.
Now, when the path of a location is invalidated, the invalidation is propagated to all the sub-paths of the location.

Furthermore, it was fixed the registration of the path when a data is transferred.
Destination folder was created, but its data location wasn't registered.

New unit tests on these two features of the data manager were added.

In addition, the signature of the register_path method of the abstract class DataManager was changed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3425b42) 67.09% compared to head (c10a4e8) 67.18%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   67.09%   67.18%   +0.08%     
==========================================
  Files          82       82              
  Lines       10253    10259       +6     
  Branches     2424     2427       +3     
==========================================
+ Hits         6879     6892      +13     
+ Misses       2950     2943       -7     
  Partials      424      424              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit b420e34 into master Dec 23, 2023
31 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/data_locs branch December 23, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants