Fix pan issue #657 #2617

mosheDa · 2017-01-23T15:58:39Z

This pull request fixes #657.

yotamberk · 2017-01-24T21:00:44Z

lib/timeline/Timeline.js

@@ -83,6 +83,9 @@ function Timeline (container, items, groups, options) {
  this.components = [];

  this.body = {
+    //moshe's code


Remove comment

yotamberk · 2017-01-24T21:01:06Z

lib/timeline/component/ItemSet.js

  // attach to the DOM
+
+
+  // moshe's code


Remove comment

yotamberk · 2017-01-24T21:03:41Z

lib/timeline/component/ItemSet.js

+      var newEnd = end + distance;
+    }
+    else
+    {


brackets don't need a new line. should be } else {

yotamberk · 2017-01-24T21:04:02Z

lib/timeline/component/ItemSet.js

+
+    if ((this.options.rtl && this.mouseLocation.mouseOnLeft)||
+      (!this.options.rtl && this.mouseLocation.mouseOnRight))
+    {


no need for new line

yotamberk · 2017-01-24T21:04:22Z

lib/timeline/component/ItemSet.js

+                  if(props.item.data.end) itemWidth = props.item.data.end.valueOf() - props.item.data.start.valueOf();           
+                  start = windowEnd - itemWidth;
+                } else 
+                { 


no need for new line

yotamberk · 2017-01-24T21:07:09Z

lib/timeline/component/ItemSet.js

+    }
+
+    this.body.dom.leftZone.onmouseleave = this.body.dom.leftContainer.onmouseleave = function()
+    {


no need for new line

yotamberk · 2017-01-24T21:07:16Z

lib/timeline/component/ItemSet.js

+    }
+
+    this.body.dom.rightZone.onmouseenter = this.body.dom.rightContainer.onmouseenter = function()
+    {


no need for new line

yotamberk · 2017-01-24T21:07:21Z

lib/timeline/component/ItemSet.js

+    }
+
+    this.body.dom.rightZone.onmouseleave = this.body.dom.rightContainer.onmouseleave = function()
+    {


no need for new line

yotamberk · 2017-01-24T21:07:32Z

lib/timeline/component/ItemSet.js

+    this.body.dom.rightZone.onmouseleave = this.body.dom.rightContainer.onmouseleave = function()
+    {
+      context.setMouseLeave(true);
+      // context.setMouseOnRight(false);


remove comment

yotamberk · 2017-01-24T21:07:51Z

lib/timeline/component/ItemSet.js

+      // context.setMouseOnRight(false);
+    }
+
+


remove comment and empty lines

mojoaxel

Please make the changes requested by @yotamberk Thanks!

mojoaxel · 2017-02-14T20:32:33Z

lib/timeline/Timeline.js

@@ -83,6 +83,8 @@ function Timeline (container, items, groups, options) {
  this.components = [];

  this.body = {
+    getWindow: this.getWindow,
+    //


please remove this line.

yotamberk · 2017-02-17T07:28:09Z

lib/timeline/Core.js

@@ -51,6 +51,8 @@ Core.prototype._create = function (container) {
  this.dom.shadowTopRight       = document.createElement('div');
  this.dom.shadowBottomRight    = document.createElement('div');
  this.dom.rollingModeBtn       = document.createElement('div');
+  this.dom.leftZone             = document.createElement('div');


I have a problem with these names. They are too generic. I think they should be renamed to: panningZoneLeft and panningZoneRight

yotamberk · 2017-02-17T07:29:12Z

lib/timeline/component/ItemSet.js

+  this.dragEvent = null;
+
+  this.mouseLocation = {mouseOnLeft: false, mouseOnRight: false, mouseIsLeaving: false}
+  var context = this;


no need for this.

yotamberk · 2017-02-17T07:29:32Z

lib/timeline/component/ItemSet.js

+  var context = this;
+
+  this.setMouseOnLeft = function(isOn){
+    context.mouseLocation.mouseOnLeft = isOn;


use this instead of context

yotamberk · 2017-02-17T07:36:00Z

lib/timeline/component/ItemSet.js

+
+  this.dragEvent = null;
+
+  this.mouseLocation = {mouseOnLeft: false, mouseOnRight: false, mouseIsLeaving: false}


I think you should not add another property referring to mouse properties. There is a this.touchParams which contains all the mouse position props. I'd attach these properties to this.touchParams instead of defining this.mouseLocation

yotamberk · 2017-03-07T19:16:50Z

The changes look fine but the tests are not passing =(

yotamberk · 2017-03-07T19:17:22Z

lib/timeline/Timeline.js

@@ -83,6 +83,7 @@ function Timeline (container, items, groups, options) {
  this.components = [];

  this.body = {
+    getWindow: this.getWindow,


this should be removed

i should add this function to this.body because i want to get the range in itemSet module and this.body sent to itemSet constructor

yotamberk · 2017-03-07T19:17:55Z

lib/timeline/component/ItemSet.js

+
+  }
+
+  var context = this;


remove context and use this

the context is needed to use setMouseOnLeft function in the mouse events for example: this.body.dom.panningZoneLeft.onmouseenter = function(){
context.setMouseOnLeft(true);
}

wimrijnders · 2017-07-06T19:24:32Z

@mosheDa The check is failing, could you please look at it? Also, there are still outstanding review items to process. A resolution of these would be greatly appreciated.

mosheDa · 2017-07-09T17:04:46Z

I am sorry I was busy for while. I am preparing to work on it as soon as possible בתאריך 6 ביולי 2017 22:24,‏ "wimrijnders" <[email protected]> כתב:

…

@mosheDa <https://github.com/mosheda> The check is failing, could you please look at it? Also, there are still outstanding review items to process. A resolution of these would be greatly appreciated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2617 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXZNdHxXB4Wp8ss6A8OFu9mHMt7gvZJSks5sLTR3gaJpZM4LrNmi> .

shawn-mcginty · 2017-08-08T04:48:29Z

Is this coming down the pike anytime soon? Would love to have this 👍

yotamberk · 2017-08-08T18:31:50Z

@mosheDa still waiting 😉

mojoaxel · 2017-08-09T06:36:37Z

lib/timeline/component/css/panel.css

+.panningZoneLeft{
+  left: 0;
+


Please remove empty line

mbroad · 2017-09-05T02:08:50Z

@mosheDa - are you looking for someone to carry these changes and finish this out for you? Or are you planning on continuing this work?

mosheDa added 5 commits January 17, 2017 11:11

add paning items near edges feature

20ff5cb

support rtl

2fd5027

support move limit

c0b92ff

move event listeners from core.js

7fddcb6

fix stop move when pan came back from outside

200be5a

Tooa added the Timeline label Jan 24, 2017

yotamberk suggested changes Jan 24, 2017

View reviewed changes

yotamberk added this to the Minor Release v4.19 milestone Jan 24, 2017

mojoaxel suggested changes Jan 30, 2017

View reviewed changes

mosheDa force-pushed the fix_pan_issue branch from 45dd249 to 050dcf9 Compare February 4, 2017 22:06

clean up code

bfd8306

mosheDa force-pushed the fix_pan_issue branch from 050dcf9 to bfd8306 Compare February 4, 2017 22:10

mojoaxel suggested changes Feb 14, 2017

View reviewed changes

yotamberk suggested changes Feb 17, 2017

View reviewed changes

mojoaxel added the waiting for answer/improvement label Feb 21, 2017

mojoaxel modified the milestones: Minor Release v4.19, Minor Release v4.20 Feb 24, 2017

mosheDa added 3 commits March 7, 2017 16:47

rename left an d right zones

3a97f28

move mouseLocation properties into touchParams object

8d23d64

use this instead 'context'

0c13c5f

yotamberk suggested changes Mar 7, 2017

View reviewed changes

yotamberk added 3 commits March 20, 2017 22:35

Merge branch 'develop' into fix_pan_issue

1ff2ba0

Merge branch 'develop' into fix_pan_issue

d64a3e8

Merge branch 'develop' into fix_pan_issue

5d453f0

mojoaxel modified the milestones: Minor Release v4.20, Patch Release v4.20.1 May 22, 2017

mojoaxel removed this from the Minor Release v4.20 milestone May 22, 2017

Merge branch 'develop' into fix_pan_issue

61f8059

Merge branch 'develop' into fix_pan_issue

9e9bc9a

mojoaxel suggested changes Aug 9, 2017

View reviewed changes

lib/timeline/component/css/panel.css

.panningZoneLeft{

left: 0;

Copy link

Member

mojoaxel Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line

mojoaxel modified the milestones: Patch Release v4.20.2, Patch Release v4.21.1, Minor Release v4.22 Oct 13, 2017

mojoaxel added Timeline waiting for answer/improvement labels Jul 27, 2019

mojoaxel mentioned this pull request Aug 2, 2019

adopt pull-requests fom vis and timeline-plus visjs/vis-timeline#36

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pan issue #657 #2617

Fix pan issue #657 #2617

mosheDa commented Jan 23, 2017 •

edited by Tooa

Loading

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

yotamberk Jan 24, 2017

mojoaxel left a comment

mojoaxel Feb 14, 2017

yotamberk Feb 17, 2017

yotamberk Feb 17, 2017

yotamberk Feb 17, 2017

yotamberk Feb 17, 2017

yotamberk commented Mar 7, 2017

yotamberk Mar 7, 2017

mosheDa Mar 7, 2017

yotamberk Mar 7, 2017

mosheDa Mar 7, 2017

wimrijnders commented Jul 6, 2017

mosheDa commented Jul 9, 2017 via email

shawn-mcginty commented Aug 8, 2017

yotamberk commented Aug 8, 2017

mojoaxel Aug 9, 2017

mbroad commented Sep 5, 2017


		this.dragEvent = null;

		this.mouseLocation = {mouseOnLeft: false, mouseOnRight: false, mouseIsLeaving: false}

Fix pan issue #657 #2617

Are you sure you want to change the base?

Fix pan issue #657 #2617

Conversation

mosheDa commented Jan 23, 2017 • edited by Tooa Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mojoaxel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yotamberk commented Mar 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wimrijnders commented Jul 6, 2017

mosheDa commented Jul 9, 2017 via email

shawn-mcginty commented Aug 8, 2017

yotamberk commented Aug 8, 2017

Choose a reason for hiding this comment

mbroad commented Sep 5, 2017

mosheDa commented Jan 23, 2017 •

edited by Tooa

Loading