Report timeout fix

[baev]

fixes #59
by @Coder1304

[korobochka]

Suggested change

	@Parameter(property = "allure.report.timeout", defaultValue = "60")
	@Parameter(property = "allure.report.timeout", defaultValue = "600")

Can I suggest a longer default value? 1 minute is not enough for big reports on Windows machines.

[Coder1304]

I know it's to short, that's why this pull was created. This value will be configurable from now, so you would be able to set it to any value you like. 60sec worked here for a long time and from all allure-maven users just two of us starts to complains about that. @baev which default value would be sufficient in your opinion?

[baev]

I'm ok with one minute timeout by default

[baev]

I don't like this to be a string as well as new introduced report timeout to be a string

[Coder1304]

@baev I send the patch on [email protected] with gh-59-fix-proposition in email subject.

[Coder1304]

@baev Could you apply this patch on top of gh-59-fix-proposition and push it? Patch contain change from String to int for timeouts.

[baev]

@Coder1304 still got no email from you, could you please resend it?

[Coder1304]

@baev I've send it again to [email protected] with gh-59-fix-proposition in the subject. And as a reply for the first mail I send you.

[baev]

Looks good to me.

In order to merge this:

• @Coder1304 you need to accept our CLA https://cla-assistant.io/allure-framework/allure-maven?pullRequest=60

• Then you need to add email address (ends with **[email protected]) to your Github account ( https://github.com/settings/emails page ) in order to link commits with your Github account

[Coder1304]

@baev I realized that I forgot to change private data. Could you change my private data to this:

removed

I would be more than happy if do this.

[CLAassistant]

All committers have signed the CLA.

[baev]

@Coder1304 done, now all we need is CLA

[Coder1304]

@baev Thanks. CLA done.

[Coder1304]

@baev I have few questions:

1. When do you plan to release this change?
2. If I would like to contribute something to this repo again the process will be the same (create issue/improvement, sending patches to the mail and hoping someone will create pull request )?
3. Commit on master branch does not contain information who is the author, why is that?

[eroshenkoam]

@Coder1304

1. It will be ready tomorrow)
2. Just create PR in this repo)
3. Fixed: https://github.com/allure-framework/allure-maven/commits/master

[Coder1304]

@eroshenkoam Could you change my data to:
--author="Coder1304 <[email protected]>"

[eroshenkoam]

done) ty for pr 👍

[Coder1304]

I have to prepare the change first. Thanks.

[Coder1304]

@eroshenkoam
I am getting problem to push anything to you repo.

$ git push -v origin HEAD:some_branch_here
Pushing to [email protected]:allure-framework/allure-maven.git
ERROR: Permission to allure-framework/allure-maven.git denied to Coder1304.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
$ git remote -v
origin	[email protected]:allure-framework/allure-maven.git (fetch)
origin	[email protected]:allure-framework/allure-maven.git (push)

Tried with ssh and https, same result.

[baev]

@Coder1304 see https://help.github.com/articles/creating-a-pull-request/

If you don't have write access to the repository where you'd like to create a pull request, you must create a fork, or copy, of the repository first. For more information, see "Creating a pull request from a fork" and "About forks."

[Coder1304]

@baev Thanks a lot for this link.