Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unify the
ManagedNonceProvider
andGasEstimatorProvider
to concurrently populate missing tx fields.Solution
Implement a
FillTxLayer
that concurrently calls the following methods:get_next_nonce
fromManagedNonceProvider
to populate thenonce
field.handle_eip1559_tx
andhandle_legacy_tx
fromGasEstimatorProvider
to populate gas related fields.get_chain_id
from provider directly to populate thechain_id
field.In order to achieve this, the following changes were made:
Introduced the
Clone
trait bound on theProvider<N, T>
forProviderBuilder
enable the cloning of the underlying provider and initializing of theManageNonceProvider
andGasEstimatorProvider
directly inFillTxLayer
Added
pub(crate) fn new
method to bothManageNonceProvider
andGasEstimatorProvider
to instantiate them directly from theFillTxLayer
PR Checklist