Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement TransactionBuilder for CallBuilder #534

Closed
mattsse opened this issue Apr 14, 2024 · 0 comments
Closed

[Feature] Implement TransactionBuilder for CallBuilder #534

mattsse opened this issue Apr 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Apr 14, 2024

Component

rpc

Describe the feature you would like

CallBuilder is a wrapper around <N: Network>::TransactionRequest which is also TransactionBuilder

alloy/crates/contract/src/call.rs

Line 259 in 56ef8ce

impl<T: Transport + Clone, P: Provider<T, N>, D: CallDecoder, N: Network> CallBuilder<T, P, D, N> {

we're currently missing crucial setters here:

ref #527

we can either also implement TransactionBuilder or duplicate all the functions of TransactionBuilder

Additional context

No response
@mattsse mattsse added the enhancement New feature or request label Apr 14, 2024
@mattsse mattsse mentioned this issue Apr 14, 2024
Closed
therainisme added a commit to therainisme/alloy that referenced this issue May 12, 2024
@therainisme
feat: duplicate funtions of in crates/contract/src/call.rs (alloy-rs#534
00b2684 
)
@therainisme therainisme mentioned this issue May 12, 2024
Merged
3 tasks
prestwich pushed a commit that referenced this issue May 12, 2024
@therainisme
feat: duplicate funtions of in crates/contract/src/call.rs (#534) (#726)
f1d7085
@mattsse mattsse closed this as completed Jul 25, 2024
ben186 pushed a commit to ben186/alloy that referenced this issue Jul 27, 2024
@therainisme
feat: duplicate funtions of in crates/contract/src/call.rs (alloy-rs#534
c89d03e 
) (alloy-rs#726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattsse