Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-export EnvKzgSettings #375

Merged
merged 3 commits into from
Mar 23, 2024
Merged

feat: re-export EnvKzgSettings #375

merged 3 commits into from
Mar 23, 2024

Conversation

prestwich
Copy link
Member

Motivation

Quality of life improvement post #349

Solution

  • re-export EnvKzgSettings from alloy-consensus to allow easy use with SidecarBuilder
  • refactor SidecarBuilder::build to use default settings
  • add SidecarBuilder::build_with_settings

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Mar 22, 2024
@prestwich prestwich self-assigned this Mar 22, 2024
@prestwich prestwich merged commit f43f329 into main Mar 23, 2024
17 checks passed
@prestwich prestwich deleted the prestwich/re-export-kzg branch March 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes