Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move Mainnet KZG group and Lazy<KzgSettings> #349

Closed
prestwich opened this issue Mar 20, 2024 · 6 comments · Fixed by #368
Closed

[Feature] Move Mainnet KZG group and Lazy<KzgSettings> #349

prestwich opened this issue Mar 20, 2024 · 6 comments · Fixed by #368
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

prestwich commented Mar 20, 2024

Component

consensus, eips, genesis

Describe the feature you would like

4844 constants in alloy-eips needs the following

  • KZG constants and files from revm-primitives
  • Lazy<Arc<KzgSettings>> and other loading methods from reth

Additional context

Should be feature-gated behind c_kzg

@prestwich prestwich added enhancement New feature or request good first issue Good for newcomers labels Mar 20, 2024
@developeruche
Copy link
Contributor

#[cfg(feature = "kzg")]
use c_kzg::{Blob, Bytes48, KzgCommitment, KzgProof, KzgSettings};

this is already behind thekzg features flag, do you intend the feature should be changed to c_kzg?

@prestwich
Copy link
Member Author

no, use whatever existing feature name 🤝

@developeruche
Copy link
Contributor

I don't think,

  1. g1_points
  2. g2_points
  3. trusted_setup

would be necessary in the alloy-eips module, what do you think?

Secondly, I am looking to add;

  1. Re-export EnvKzgSettings from the revm-primitive env_settings.rs
  2. Re-export all public const from revm-primitive trusted_setup_points.rs

what are your thoughts?

@developeruche
Copy link
Contributor

@prestwich

@mattsse
Copy link
Member

mattsse commented Mar 21, 2024

all of the utils and constants defined on revm should be moved here, then once we have a release we can replace them in revm with our crate

@developeruche
Copy link
Contributor

developeruche commented Mar 21, 2024

Alright... that makes sense, on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants