fix(radio-button): no random suffix for custom ID (#1116)

allianz · Feb 1, 2024 · 65d9828 · 65d9828
1 parent cc5f666
commit 65d9828
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/projects/ng-aquila/src/radio-button/radio-button.spec.ts b/projects/ng-aquila/src/radio-button/radio-button.spec.ts
@@ -357,7 +357,7 @@ describe('NxRadioComponent', () => {
             radioInstance.id = 'custom-radio-id';
             fixture.detectChanges();
             const radioElement = fixture.nativeElement.querySelector('nx-radio');
-            expect(getRadioInputElement(radioElement).getAttribute('id')?.startsWith('custom-radio-id-input')).toBeTrue();
+            expect(getRadioInputElement(radioElement).getAttribute('id')).toBe('custom-radio-id-input');
             expect(getRadioLabelElement(radioElement).getAttribute('id')).toBe('custom-radio-id-label');
         });
 

diff --git a/projects/ng-aquila/src/radio-button/radio-button.ts b/projects/ng-aquila/src/radio-button/radio-button.ts
@@ -280,13 +280,12 @@ export class NxRadioComponent implements ControlValueAccessor, OnInit, AfterView
     get id(): string {
         return this._id;
     }
-    private _id = `nx-radio-${nextId++}`;
 
-    private _inputIdSuffix = randomString();
+    private _id = `nx-radio-${nextId++}-${randomString()}`;
 
     /** @docs-private */
     get inputId(): string {
-        return `${this.id}-input-${this._inputIdSuffix}`;
+        return `${this.id}-input`;
     }
 
     /** @docs-private */