[Feature] Unit tests for the Full-Page Caching for 404s feature #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ractive/wp-alleyvate into feature/9/caching-404s
renatonascalves
commented
Feb 13, 2024
|
Looks like the php-cs-fixer doesn't like the |
|
I made it work but it seems we have conflicting tools here asking for different rules: |
|
Getting the object-cache to work here is proving more complicated than expected. Moving on as it is for now while I search for better support. Probably changing https://github.com/alleyinteractive/.github/blob/main/.github/workflows/php-tests.yml |
kevinfodness
approved these changes
Feb 14, 2024
| $url = home_url( self::TEMPLATE_GENERATOR_URI, 'https' ); | ||
|
|
||
| // Replace http with https to ensure the styles don't get blocked due to insecure content. | ||
| $url = str_replace( 'http://', 'https://', $url ); | ||
|
|
||
| // This request will populate the cache using output buffering. | ||
| if ( function_exists( 'wpcom_vip_file_get_contents' ) ) { | ||
| if ( \function_exists( 'wpcom_vip_file_get_contents' ) ) { |
There was a problem hiding this comment.
Why is the slash being added here?
There was a problem hiding this comment.
This is being added by the php-cs-fixer. Not sure yet why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled.
Notes for reviewers
See #46