Fix warnings (#46)

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "allestuetsmerweh/php-typescript-api",
-    "version": "2.6.9",
+    "version": "2.6.10",
     "type": "library",
     "description": "Build a typed Web API using PHP and TypeScript",
     "keywords": ["PHP","TypeScript","API"],

package.json

@@ -1,6 +1,6 @@
 {
   "name": "php-typescript-api",
-  "version": "2.6.9",
+  "version": "2.6.10",
   "description": "Build a typed Web API using PHP and TypeScript",
   "main": "client/lib/index.js",
   "types": "client/lib/index.d.ts",

server/lib/Translator.php

@@ -15,7 +15,8 @@ class Translator {
     protected array $fallback_chain = ['en'];
 
     public function readProjectLangs(): void {
-        $entries = scandir($this::$lang_path);
+        $entries = is_dir($this::$lang_path)
+            ? scandir($this::$lang_path) : false;
         if (!$entries) {
             return;
         }
@@ -120,7 +121,8 @@ protected function getLangMessage(string $id): ?array {
     protected function readMessagesJson(string $lang): array {
         $lang_path = $this::$lang_path;
         $messages_json_path = "{$lang_path}{$lang}/messages.json";
-        $messages_json_content = file_get_contents($messages_json_path);
+        $messages_json_content = is_file($messages_json_path)
+            ? file_get_contents($messages_json_path) : false;
         if (!$messages_json_content) {
             return [];
         }

server/lib/TypedEndpoint.php

@@ -94,8 +94,11 @@ protected function getTemplateAliases(
             $node = $template_nodes[$i];
             $value = $args[$i] ?? $node->default;
             if ($value === null) {
+                // @codeCoverageIgnoreStart
+                // Reason: phpstan does not allow testing this!
                 $pretty_generics = implode(', ', $args);
                 throw new \Exception("This should never happen: Template[{$i}] is null. Expected {$pretty_range} generic arguments, got '{$previous_extends_node?->type->type}<{$pretty_generics}>'");
+                // @codeCoverageIgnoreEnd
             }
             $aliases[$node->name] = $value;
         }
@@ -109,7 +112,7 @@ protected function getResolvedExtendsNode(
         ?PhpDocNode $php_doc_node,
         array $template_aliases,
     ): ?ExtendsTagValueNode {
-        $extends_type_node = $php_doc_node?->getExtendsTagValues()[0];
+        $extends_type_node = $php_doc_node?->getExtendsTagValues()[0] ?? null;
         if (!$extends_type_node) {
             return null;
         }

server/tests/UnitTests/TypedEndpointTest.php

@@ -444,6 +444,14 @@ public function testFakeTypedEndpointRuntimeSetup(): void {
         ], $this->fakeLogHandler->getPrettyRecords());
     }
 
+    public function testFakeTypedEndpointRuntimeSetupFallback(): void {
+        global $_GET, $_POST;
+        $endpoint = new FakeTypedEndpointWithErrors();
+        $endpoint->setLogger($this->fakeLogger);
+        $endpoint->setup();
+        $this->assertSame([], $this->fakeLogHandler->getPrettyRecords());
+    }
+
     public function testFakeTypedEndpointWithThrottling(): void {
         $endpoint = new FakeTypedEndpointWithErrors();
         $endpoint->setLogger($this->fakeLogger);