This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in fix for the SimpleEvaluator not initializing a post processor
@AkshitaB Sorry for the delay but here is the draft. Handling extra metrics is not yet implemented, but I felt like this was already big enough to warrant a PR |
AkshitaB
suggested changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabeorlanski Looks great, overall! I left some comments/suggestions.
AkshitaB
approved these changes
Jan 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5405.
Changes proposed in this pull request:
Evaluator
Base class that serves as a way to evaluate and post-process a single data set.The new
Postprocessor
Base Class will post-process both batch inputs and output predictions into a human-readable string format.SimpleEvaluator
andSimplePostprocessor
are implemented to replicate the original evaluation behavior.Evaluate
class."evaluation" that maps directly to an
Evaluator` sub-class. (Placeholder poping of this from the config was added to the train function so that it does not break).evaluate
to have this key and will default to the original behavior.Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.