This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
This is a desperate attempt to make TensorCache a little more stable #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
reviewed
Jul 27, 2021
| @@ -641,8 +641,8 @@ def __init__( | |||
| str(filename), | |||
| subdir=False, | |||
| map_size=map_size, | |||
| max_readers=cpu_count * 2, | |||
| max_spare_txns=cpu_count * 2, | |||
| max_readers=cpu_count * 4, | |||
There was a problem hiding this comment.
Should we have an option to specify the kwargs in TensorCache's init? Or do we want to shield the users from the gory details?
There was a problem hiding this comment.
I wanted to shield users from this. It seems like an implementation detail. Another implementation might not have that setting at all.
AkshitaB
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.