This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Adding a min_steps parameter to BeamSearch
#5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
May 17, 2021
There was a problem hiding this comment.
Thanks @danieldeutsch, this looks great! I just have one comment
allennlp/nn/beam_search.py
Outdated
| @@ -471,19 +475,25 @@ def __init__( | |||
| beam_size: int = 10, | |||
| per_node_beam_size: int = None, | |||
| sampler: Sampler = None, | |||
| min_steps: int = 0, | |||
There was a problem hiding this comment.
I think making this an Optional[int] is more clear.
Suggested change
| min_steps: int = 0, | |
| min_steps: Optional[int] = None, |
There was a problem hiding this comment.
Ok, I pushed this change. I had to change the code to make sure the value is valid, too.
10 tasks
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
* Implementing minimum number of decoding steps * Adding unit tests * Reformatting * Adding entry to changelog * Adding end token comment * Adding start token comment * Changing param to optional Co-authored-by: Pete <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature request 1 from #5205.
Changes proposed in this pull request:
min_stepsparameter toBeamSearch, which allows specifying the minimum length of the predicted sequences. This is commonly used in tasks like summarization, for instance by BARTBefore submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting
codecov/patchreports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.