This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update transformers requirement from <3.6,>=3.4 to >=3.4,<4.1 #4831
Merged
AkshitaB
merged 6 commits into
master
from
dependabot/pip/transformers-gte-3.4-and-lt-4.1
Dec 11, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
95c000e
Update transformers requirement from <3.6,>=3.4 to >=3.4,<4.1
dependabot[bot] e6e6a93
Merge branch 'master' into dependabot/pip/transformers-gte-3.4-and-lt…
AkshitaB 1a77693
updates for transformers==4.0.1
AkshitaB e931b3b
update changelog
AkshitaB bd63ab9
adding sentencepiece as dependency
AkshitaB f635b2f
Update setup.py
AkshitaB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,7 +99,7 @@ def test_transformers_vocab_sizes(self, model_name): | |
|
||
def test_transformers_vocabs_added_correctly(self): | ||
namespace, model_name = "tags", "roberta-base" | ||
tokenizer = cached_transformers.get_tokenizer(model_name) | ||
tokenizer = cached_transformers.get_tokenizer(model_name, use_fast=False) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
allennlp_tokenizer = PretrainedTransformerTokenizer(model_name) | ||
indexer = PretrainedTransformerIndexer(model_name=model_name, namespace=namespace) | ||
allennlp_tokens = allennlp_tokenizer.tokenize("AllenNLP is great!") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the release notes,
sentencepiece
is not required as a dependency intransformers
by default. But we use certain tokenizers from HF that require it.