This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix: removes all handlers from the root logger #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
suggested changes
Dec 1, 2020
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Added links to source code in docs. | |||
| - Fixed issue with GradientDescentTrainer when constructed with validation_data_loader==None and learning_rate_scheduler!=None. | |||
| - Fixed issue with removing all handlers in root logger. | |||
There was a problem hiding this comment.
This should be under the ### Fixed section (you may need to create this section if it doesn't exist under the ## Unreleased section.
There was a problem hiding this comment.
@epwalsh Does it look okay now? BTW, I've also moved the above fixed to this new section.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not mutate (insert/remove elements) the list you're currently iterating on. In fact, this causes handlers to not be completely deleted on my side.
For more discussion, see https://stackoverflow.com/questions/7484454/removing-handlers-from-pythons-logging-loggers