This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
support global plugins file, improve plugins docs #4779
Merged
+70
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
suggested changes
Nov 10, 2020
allennlp/common/plugins.py
Outdated
Comment on lines
59
to
63
| if os.path.isfile(LOCAL_PLUGINS_FILENAME): | ||
| with push_python_path("."): | ||
| yield from discover_file_plugins(LOCAL_PLUGINS_FILENAME) | ||
| elif os.path.isfile(GLOBAL_PLUGINS_FILENAME): | ||
| yield from discover_file_plugins(GLOBAL_PLUGINS_FILENAME) |
There was a problem hiding this comment.
This means only one of the files will be respected. Wouldn't it make more sense to load from both files if they are both present?
There was a problem hiding this comment.
I think either way would make sense. I don't feel strongly about it, so I'm happy to make the change if you do.
allennlp/common/plugins.py
Outdated
Comment on lines
64
to
65
| else: | ||
| yield from [] |
There was a problem hiding this comment.
I don't think you need this. You can just let the function end.
dirkgr
approved these changes
Nov 10, 2020
| @@ -56,13 +55,20 @@ def discover_plugins() -> Iterable[str]: | |||
| """ | |||
| Returns an iterable of the plugins found. | |||
| """ | |||
| plugins: Set[str] = set() | |||
| if os.path.isfile(LOCAL_PLUGINS_FILENAME): | |||
| with push_python_path("."): | |||
There was a problem hiding this comment.
The global one doesn't need this?
There was a problem hiding this comment.
I guess the assumption made with global plugins is that they should be installed in your virtual environment, rather than just existing in the current directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for declaring a global plugins file at
~/.allennlp/pluginsand improves the documentation for plugins. This also closes #4775 by added a place to display third-party plugins.