Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Pass batch metrics to BatchCallback #4764

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Pass batch metrics to BatchCallback #4764

merged 3 commits into from
Nov 10, 2020

Conversation

eladsegal
Copy link
Contributor

No description provided.

@AkshitaB AkshitaB requested a review from dirkgr November 6, 2020 17:21
dirkgr
dirkgr suggested changes Nov 6, 2020
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I can't remember if we discussed this somewhere or if you just read my mind.

Can you add a changelog entry?

@eladsegal
Copy link
Contributor Author

This is great! I can't remember if we discussed this somewhere or if you just read my mind.

Can you add a changelog entry?

Just a coincidence :)
Changelog entry was added

@dirkgr dirkgr merged commit 764bbe2 into allenai:master Nov 10, 2020
@eladsegal eladsegal deleted the batch_metrics branch November 11, 2020 03:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eladsegal @dirkgr