This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
New version of transformers #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Apr 4, 2020
| @@ -258,7 +269,7 @@ def test_token_idx_sentence_pairs(self): | |||
| ".", | |||
| "</s>", | |||
| "</s>", | |||
| "It", | |||
| "ĠIt", | |||
There was a problem hiding this comment.
Do you know why it's adding spaces to the first token? Is that expected?
There was a problem hiding this comment.
I think it's a change in defaults.
At first, people thought that Ġ means that this is the beginning of the word (opposite of ## in BERT). So then people were complaining about the "bug" where the Ġ wasn't there at the beginning of the first token, and they made a fix. But now it means "space", so not having it makes sense ... I want to not get involved and just stick with the huggingface default.
setup.py
Outdated
| @@ -119,7 +119,7 @@ | |||
| "flaky", | |||
| "responses>=0.7", | |||
| "conllu==2.3.2", | |||
| "transformers>=2.4.0,<2.5.0", | |||
| "transformers>=2.6.0", | |||
There was a problem hiding this comment.
Are you sure you don't want to keep an upper bound?
There was a problem hiding this comment.
Probably a good idea. Added in 3264dcc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.