Query for topics metrics #794
Conversation
| @Test(dataProvider = "topicsMetricsFilteringData") | ||
| public void shouldQueryTopicsMetrics(String query, List<String> qualifiedNames) { | ||
| // given | ||
| operations.buildTopic(topic("testGroup", "testTopic1").withContentType(JSON).withTrackingEnabled(false).build()); |
There was a problem hiding this comment.
no need for .withTrackingEnabled()
| import org.apache.commons.jxpath.JXPathException; | ||
| import pl.allegro.tech.hermes.management.infrastructure.query.graph.ObjectGraph; | ||
|
|
||
| public class GraterThanMatcher implements Matcher { |
There was a problem hiding this comment.
That's duplicated with LowerThanMatcher. How about creating a ComparisonMatcher which would receive an operator function of (double, double) => boolean as parameter? Then implementing GreaterThanMatcher and LowerThanMatcher would just mean configuring it in a proper way, e.g.:
- greater: new ComparisonMatcher(path, parser.parseValue(node), (a, b) -> a > b);
- lower: new ComparisonMatcher(path, parser.parseValue(node), (a, b) -> a < b);
| import org.apache.commons.jxpath.JXPathException; | ||
| import pl.allegro.tech.hermes.management.infrastructure.query.graph.ObjectGraph; | ||
|
|
||
| public class GraterThanMatcher implements Matcher { |
| @@ -0,0 +1,7 @@ | |||
| package pl.allegro.tech.hermes.management.infrastructure.query.matcher; | |||
|
|
|||
| public class MatcherInputException extends RuntimeException { | |||
There was a problem hiding this comment.
please extend ManagementException, so you'll be able to get rid of MatcherExceptionMapper
| import pl.allegro.tech.hermes.api.Subscription; | ||
| import pl.allegro.tech.hermes.api.Topic; | ||
| import pl.allegro.tech.hermes.api.Query; | ||
| import pl.allegro.tech.hermes.api.*; |
There was a problem hiding this comment.
IMO these wildcards are too greedy :) please tune your IDE, so explicit imports will be left instead.
|
|
||
| public String getQualifiedName() { | ||
| return topicName.qualifiedName(); | ||
| } |
There was a problem hiding this comment.
missing equals + hashcode ?
| import javax.ws.rs.ext.Provider; | ||
|
|
||
| @Provider | ||
| public class MatcherExceptionMapper extends AbstractExceptionMapper<MatcherInputException> { |
There was a problem hiding this comment.
this class can be removed, see comment for MatcherInputException
| return query.filter( | ||
| getAllTopics() | ||
| .stream() | ||
| .map(t -> { |
There was a problem hiding this comment.
A private method doing this map() logic here would be nice so we could method-reference it
|
|
||
| @Override | ||
| public boolean match(Object value) { | ||
| try { |
There was a problem hiding this comment.
this try-catch is a bit wide, maybe we should divide it into smaller parts (separated graph navigation, greater-than decision logic)?
This pull request adds additional endpoint (/query/topics/metrics) which handle POST method for fetching list of topics metrics. Two new options for filtering data were added. They are GRATER_THAN and LOWER_THAN operator. Simple example for filtering topics metrics using one of them:
POST /query/topics/metrics
{
"query": {"rate": {"gt": 0}}
}