Schema-registry integration #593
Conversation
dankraw
force-pushed
the
schema-registry
branch
3 times, most recently
from
a0fbe68 to
016b344
Compare
dankraw
force-pushed
the
schema-registry
branch
2 times, most recently
from
9f1e3f9 to
330b1ae
Compare
dankraw
force-pushed
the
schema-registry
branch
from
330b1ae to
51b9896
Compare
|
|
||
| import java.util.Optional; | ||
|
|
||
| import static pl.allegro.tech.hermes.api.ContentType.AVRO; | ||
| import static pl.allegro.tech.hermes.api.TopicName.fromQualifiedName; | ||
|
|
||
| @Component | ||
| public class SchemaSourceService { |
There was a problem hiding this comment.
i wonder - we use term schema source everywhere and i don't know if it's a proper one - schema source sounds like source of schema aka schema repository, while what we mean is schema itself (aka raw schema in text format). Maybe it's a good time to change this?
There was a problem hiding this comment.
Agreed, I'll rename it to RawSchema.
| @@ -0,0 +1,240 @@ | |||
| package pl.allegro.tech.hermes.schema.schemarepo; | |||
There was a problem hiding this comment.
why is it in java and not groovy? this is weird, as other tests are in groovy in this module
There was a problem hiding this comment.
I've been reusing old tests, transforming them to groovy shouldn't take long. :)
There was a problem hiding this comment.
OK, all hermes-schema tests are now groovy :)
|
I'm mostly confused with the naming, but all in all - good job :) |
This PR introduces support for Confluent Schema Registry as the next default Avro schema repository.
Important changes:
hermes-console) - from now on schemas are supported for Avro topics onlyhermes-schemamodule for schema-related content (note: DI-factory classes, Avro message wrappers / SerDe are left inhermes-common)