Extend UI topic view by new field: fallbackToRemoteDatacenterEnabled #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczygiel-m
previously approved these changes
Jan 23, 2025
szczygiel-m
previously approved these changes
Jan 31, 2025
moscicky
reviewed
Feb 5, 2025
| @@ -366,6 +367,8 @@ const en_US = { | |||
| 'Should data from this topic be stored in offline storage (e.g. HDFS).', | |||
| offlineRetention: | |||
| 'For how long should this topic be stored in offline storage.', | |||
| fallbackToRemoteDatacenterEnabled: | |||
| 'In case of message publishing failure, Hermes fallback to a remote DC instead of store unsent messages in offline storage. Enabling fallback to remote DC increase your messages durability but may impact publishing latency.', | |||
There was a problem hiding this comment.
In the event of a message publishing failure, Hermes falls back to a remote data center instead of storing unsent messages on local disk. Enabling fallback to the remote data center increases the durability of your messages but may impact the publishing latency and increase number of duplicated messages.
moscicky
previously approved these changes
Feb 5, 2025
This reverts commit b871782.
moscicky
approved these changes
Feb 5, 2025
szczygiel-m
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.