Allow for 'empty' broadcast send attempt #1876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for a bug that would cause a broadcast message to be undeliverable. Consider a following scenario:
A
with instancesA1
,A2
andA3
A1
andA2
but fails to be delivered toA3
A1
andA2
(perhaps there was ongoing rolling upgrade andA3
was terminated)Previously, when that situation occurred the message would be retried until its TTL expired -
A1
andA2
were already marked as succeeded and so they were not added tochildren
ofMultiMessageSendingResult
.children
was an empty list which was considered a failure so the message was retried. This would go on as long as the set of uris returned fromEndpointAddressResolver
equals the set ofsucceededUris
from message.Starting from this PR
children
will contain sent messages from all attempts so a 'empty' send would not be considered a failure.