allow configuration of default value for remoteDatacenterFallbackEnabled #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moscicky
force-pushed
the
default-remote-datacenter-fallback-enabled
branch
2 times, most recently
from
24e4624 to
33630c6
Compare
moscicky
force-pushed
the
default-remote-datacenter-fallback-enabled
branch
from
33630c6 to
b9dfb09
Compare
szczygiel-m
reviewed
Jun 25, 2024
| //then | ||
| response.expectStatus().isOk(); | ||
| Topic t = hermes.api().getTopicResponse(topic.getQualifiedName()).returnResult(Topic.class).getResponseBody().blockFirst(); | ||
| System.out.println("Aaa"); |
There was a problem hiding this comment.
I think this was for debugging purposes 😛
szczygiel-m
approved these changes
Jul 1, 2024
druminski
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a default value for topic property
fallbackToRemoteDatacenterEnabledconfigurable via:topic.defaultFallbackToRemoteDatacenterEnabledfor managementfrontend.topic.defaults.fallbackToRemoteDatacenterEnabledfor frontendThis will enable configuring whether newly created topics and topics with missing property should have fallback turned on by default or not.