Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition to error state upon failing publishing handler #1868

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

moscicky
Copy link
Collaborator

@moscicky moscicky commented Jun 10, 2024

Transition to failed state when publishing handler throws exception. Without it a timeout handler would run after a response was already sent. This would in turn always log

Not sending error message to a client as response has already been started.

@moscicky moscicky added the bug label Jun 11, 2024
@moscicky moscicky marked this pull request as ready for review June 11, 2024 08:17
@moscicky moscicky merged commit 5587796 into master Jun 12, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants