Feature/actions #1712
Merged
Feature/actions #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hermes-console-vue/src/api/hermes-client/index.ts # hermes-console-vue/src/views/topic/TopicView.vue # hermes-console-vue/src/views/topic/topic-header/TopicHeader.vue
# Conflicts: # hermes-console-vue/src/views/topic/TopicView.vue
…roved search pattern regex
# Conflicts: # hermes-console-vue/json-server/server.ts # hermes-console-vue/src/api/hermes-client/index.ts # hermes-console-vue/src/main.ts # hermes-console-vue/vitest.setup.ts
moscicky
reviewed
Aug 29, 2023
| const isDialogOpened = ref(isOpenedByDefault); | ||
| const actionButtonEnabled = ref(actionButtonEnabledByDefault); | ||
|
|
||
| async function openDialog() { |
There was a problem hiding this comment.
why are all these functions async? They are not doing any asynchronous work and we are not awaiting them when they are used. I suggest we make them sync
| import { dummyRoles } from '@/dummy/roles'; | ||
| import { dummyTopic, dummyTopicOwner } from '@/dummy/topic'; | ||
| import { render } from '@/utils/test-utils'; | ||
| import { Role } from '@/api/role'; | ||
| import TopicHeader from '@/views/topic/topic-header/TopicHeader.vue'; | ||
|
|
||
| describe('TopicHeader', () => { |
There was a problem hiding this comment.
minor: perhaps we should test whether remove event is emitted on button click
|
|
||
| const { | ||
| isDialogOpened: isRemoveDialogOpened, | ||
| actionButtonEnabled: actionRemoveButtonEnabled, |
There was a problem hiding this comment.
Suggested change
| actionButtonEnabled: actionRemoveButtonEnabled, | |
| actionButtonEnabled: removeActionButtonEnabled, |
| @@ -13,6 +13,8 @@ | |||
| (topic) => !props.filter || topic.includes(props.filter), | |||
| ); | |||
| }); | |||
|
|
|||
| defineEmits(['remove']); | |||
There was a problem hiding this comment.
consider using typed emits to make argument types clear: https://vuejs.org/guide/typescript/composition-api.html#typing-component-emits
| @@ -28,4 +28,5 @@ export const useNotificationsStore = defineStore('notifications', { | |||
| ); | |||
| }, | |||
| }, | |||
| persist: true, | |||
| @@ -68,11 +68,14 @@ export function useSearch(): UseSearch { | |||
| }; | |||
| } | |||
|
|
|||
| const patternPrefix = '(?i).*'; | |||
| const patternSuffix = '.*'; | |||
There was a problem hiding this comment.
can be confusing that user types in regex but his regex is only in the middle of our regex. But I agree that this will make life easier for average user
| @@ -50,4 +66,44 @@ describe('useInconsistentTopics', () => { | |||
| expect(error.value.fetchInconsistentTopics).not.toBeNull(); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should show message that removing subscription was successful', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should show message that removing subscription was successful', async () => { | |
| it('should show message that removing inconsistentTopic was successful', async () => { |
| @@ -1,4 +1,5 @@ | |||
| import { beforeEach } from 'vitest'; | |||
| import { dummyOwner } from '@/dummy/topic'; | |||
| import { dummySubscription } from '@/dummy/subscription'; | |||
| import { expect } from 'vitest'; | |||
| import { render } from '@/utils/test-utils'; | |||
There was a problem hiding this comment.
minor: we can consider adding tests for checking whether events were emitted on btn clicks
| }); | ||
| }); | ||
|
|
||
| it('should show message that removing subscription was unsuccessful', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should show message that removing subscription was unsuccessful', async () => { | |
| it('should show message that removing topic was unsuccessful', async () => { |
| ).toBeDisabled(); | ||
| }); | ||
|
|
||
| it('should require confirmation text', () => { |
moscicky
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added actions for: