Hermes console vue move offsets #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moscicky
force-pushed
the
hermes_console_vue_move_offsets
branch
from
e0a4869 to
deceba1
Compare
szczygiel-m
previously approved these changes
Aug 22, 2023
| import { useI18n } from 'vue-i18n'; | ||
|
|
||
| const props = defineProps<{ | ||
| subscription: Subscription; |
There was a problem hiding this comment.
What do You think about passing just topicName and subscriptionName instead the whole Subscription object?
|
|
||
| const msg = ref<string>(); | ||
|
|
||
| function moveOffsets(): void { |
There was a problem hiding this comment.
I think this function should be in composables
| $t('subscription.moveOffsets.button') | ||
| }}</v-btn> | ||
| <!-- TODO: show a popup--> | ||
| <p class="text-wrap">{{ msg }}</p> |
There was a problem hiding this comment.
For now, we can omit error/success messages printing. I think that it is better to add this as notification (included in Adrian's subscription form PR). Also lets omit confirmation popups for now, we will add this in separate PR.
| validateStatus: (status: number) => { | ||
| return status > 200 && status < 400; | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Am I thinking right, that lines 131-135 are not necessary?
moscicky
force-pushed
the
hermes_console_vue_move_offsets
branch
from
deceba1 to
f23a6d4
Compare
moscicky
force-pushed
the
hermes_console_vue_move_offsets
branch
from
f23a6d4 to
c320a7e
Compare
szczygiel-m
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.