Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

When no version is provided to the EmbeddedElastic.Builder AutoDetectElasticVersion tries to auto-detect the elasticsearch version #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jvwilge
Copy link

@jvwilge jvwilge commented Jan 6, 2019

Providing the elasticsearch version is a bit of a redundant step since it can be found in the filename of the elasticsearch client jar. With auto-detect you don't have to keep the jar and embedded-elastic in sync. Providing the version still works as before.
Tested with java 8 and 11.

…ElasticVersion tries to auto-detect the elasticsearch version
@giampaolotrapasso
Copy link

Hi @jvwilge, does this resolve #93?

@jvwilge
Copy link
Author

jvwilge commented Aug 23, 2019

Hi @jvwilge, does this resolve #93?

Nope, my PR tries to determine the elasticsearch version and I guess you already provided the version yourself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants